Reviewers: Toon Verwaest,
Message:
PTAL
Description:
Don't disable hash randomization option in predictable mode.
We don't need it because
1) hash randomization uses random generator whose results depend on
--random-seed option which is set in predictable mode.
2) disabling hash randomization triggers assert in snapshot mode.
Please review this at https://codereview.chromium.org/171813015/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -2 lines):
M src/flag-definitions.h
M src/v8.cc
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
476e5348af3dd96ea158c27559c29171d660903d..aefda0ee884a67070e547a48f946598ac5e4a350
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -648,7 +648,6 @@ DEFINE_bool(profile_hydrogen_code_stub_compilation,
false,
"Print the time it takes to lazily compile hydrogen code
stubs.")
DEFINE_bool(predictable, false, "enable predictable mode")
-DEFINE_neg_implication(predictable, randomize_hashes)
DEFINE_neg_implication(predictable, concurrent_recompilation)
DEFINE_neg_implication(predictable, concurrent_osr)
DEFINE_neg_implication(predictable, concurrent_sweeping)
Index: src/v8.cc
diff --git a/src/v8.cc b/src/v8.cc
index
28454b437e5d9f75141572e37865b01e3220dfae..489d0553bd9ecbb0e19967af9a5778a7d13a989c
100644
--- a/src/v8.cc
+++ b/src/v8.cc
@@ -190,7 +190,6 @@ void V8::InitializeOncePerProcessImpl() {
// Avoid random seeds in predictable mode.
FLAG_random_seed = 12347;
}
- FLAG_hash_seed = 0;
}
if (FLAG_stress_compaction) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
