https://codereview.chromium.org/173793002/diff/40001/src/date.h
File src/date.h (right):
https://codereview.chromium.org/173793002/diff/40001/src/date.h#newcode125
src/date.h:125: void CheckTimezone() {
looks like you follow surround code and inlined the implementation in
the header file.
Is that better? Does it generate better code? Is it cheap?
If later in time you come and change this implementation, it will
recompile a bunch of files that include date.h because you make a change
in the header. Otherwise if you implement in the source file, then just
date.cc will have to be compiled again if I'm not wrong.
https://codereview.chromium.org/173793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
