Reviewers: jochen,
Message:
Committed patchset #1 manually as r19528 (presubmit successful).
Description:
A64: Remove a couple of already addressed TODOs.
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=19528
Please review this at https://codereview.chromium.org/173773002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -4 lines):
M src/a64/code-stubs-a64.cc
M src/a64/lithium-a64.cc
Index: src/a64/code-stubs-a64.cc
diff --git a/src/a64/code-stubs-a64.cc b/src/a64/code-stubs-a64.cc
index
21bb2f85bb722d0a9f964b01481384d1c5d07434..a13293eac7650b76f39db2dc4e7e5d249827c3eb
100644
--- a/src/a64/code-stubs-a64.cc
+++ b/src/a64/code-stubs-a64.cc
@@ -1884,8 +1884,6 @@ void JSEntryStub::GenerateBody(MacroAssembler* masm,
bool is_construct) {
// x2: receiver.
// x3: argc.
// x4: argv.
- // TODO(jbramley): The latest ARM code checks is_construct and
conditionally
- // uses construct_entry. We probably need to do the same here.
ExternalReference entry(is_construct ?
Builtins::kJSConstructEntryTrampoline
: Builtins::kJSEntryTrampoline,
isolate);
Index: src/a64/lithium-a64.cc
diff --git a/src/a64/lithium-a64.cc b/src/a64/lithium-a64.cc
index
d9f51e2edb49bb3bbe45216cc25e8aa0296fa7ff..b3302667815b2acdc5ec6f6f08ccf70b916504dd
100644
--- a/src/a64/lithium-a64.cc
+++ b/src/a64/lithium-a64.cc
@@ -1246,8 +1246,6 @@ LInstruction*
LChunkBuilder::DoCompareNumericAndBranch(
HCompareNumericAndBranch* instr) {
Representation r = instr->representation();
- // TODO(all): This instruction has been replaced by
HCompareNumericAndBranch
- // on bleeding_edge. We should update when we'll do the rebase.
if (r.IsSmiOrInteger32()) {
ASSERT(instr->left()->representation().Equals(r));
ASSERT(instr->right()->representation().Equals(r));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
