Do you mind using git? If not, I would recommend read this instructions https://code.google.com/p/v8/wiki/UsingGit.
It should be pretty easy to upload a patch for review using git + depot_tools tools (git cl upload). Best, On Fri, Feb 21, 2014 at 4:41 PM, <[email protected]> wrote: > Hello, > > I am working on Node.js core and I am trying to suggest a patch (attached) > for v8 for https://github.com/joyent/node/issues/7120. > > I followed all the instructions on the Wiki on how to contribute but had > no luck with uploading the patch for review, both using git and svn. > > *With git:* > git cl config http://v8.googlecode.com/svn > Traceback (most recent call last): > File "c:\Node\depot_tools\\git_cl.py", line 2439, in <module> > sys.exit(main(sys.argv[1:])) > File "c:\Node\depot_tools\\git_cl.py", line 2425, in main > return dispatcher.execute(OptionParser(), argv) > File "c:\Node\depot_tools\subcommand.py", line 245, in execute > return command(parser, args[1:]) > File "c:\Node\depot_tools\\git_cl.py", line 1133, in CMDconfig > LoadCodereviewSettingsFromFile(urllib2.urlopen(url)) > File "c:\Node\depot_tools\\git_cl.py", line 1030, in > LoadCodereviewSettingsFromFile > keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read()) > File "c:\Node\depot_tools\gclient_utils.py", line 902, in > ParseCodereviewSettingsContent > 'Failed to process settings, please fix. Content:\n\n%s' % content) > gclient_utils.Error: Failed to process settings, please fix. Content: > > <html><head><title>v8 - Revision 19529: /</title></head> > <body> > <h2>v8 - Revision 19529: /</h2> > <ul> > <li><a href="branches/">branches/</a></li> > <li><a href="codereview.settings">codereview.settings</a></li> > <li><a href="data/">data/</a></li> > <li><a href="tags/">tags/</a></li> > <li><a href="trunk/">trunk/</a></li> > <li><a href="wiki/">wiki/</a></li> > </ul> > <hr noshade><em><a href="http://code.google.com/";>Google Code</a> > powered by <a href="http://subversion.apache.org/";>Subversion</a></em> > </body></html> > > And then when I try git cl upload: > Total errors found: 122 > Total violating files: 0 > > ** Presubmit Messages ** > Missing OWNER reviewers for these files: > src\bootstrapper.cc > src\isolate.h > > Suggested OWNERS: (Use "git-cl owners" to interactively select owners.) > [email protected] > > ** Presubmit ERRORS ** > C++ lint check failed > > Presubmit checks took 46.9s to calculate. > > Those 122 error seem legit but are not files that I touched. I just cloned > the repo from github. > > *When using svn:* > c:\v8>gcl change mychange > To use gcl, you need to be in a subversion checkout. > > ...and that's the root of my subversion checkout. > > Any help would be greatly appreciated. I am looking forward to getting > feedback on this patch. > > Thanks, > Alexis Campailla > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- Thiago Farina -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
