LGTM. Please wait to land this (Haitao can do this for you) until the tree
re-opens when the current stability issues have been fixed.
https://codereview.chromium.org/174693002/diff/1/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):
https://codereview.chromium.org/174693002/diff/1/src/x64/lithium-x64.cc#newcode2020
src/x64/lithium-x64.cc:2020: val = UseRegisterAtStart(instr->value());
This is a little shady, but probably OK. In the NaN canonicalization in
the code generator the value register get changed from one NaN to
another NaN... technically an overwrite, but harmless given how we treat
most NaNs uniformly, I think it's safe.
https://codereview.chromium.org/174693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.