Reviewers: dcarney,
Description:
Check that after a weak callback, the handle is either dead or strong
BUG=346061
[email protected]
LOG=y
Please review this at https://codereview.chromium.org/177943002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/global-handles.cc
Index: src/global-handles.cc
diff --git a/src/global-handles.cc b/src/global-handles.cc
index
09449791f4f2352411c31e1ad5f82caaa692a1d7..211bb1c77486bafd754a91854dabbf95355c8e14
100644
--- a/src/global-handles.cc
+++ b/src/global-handles.cc
@@ -271,7 +271,7 @@ class GlobalHandles::Node {
}
// Absence of explicit cleanup or revival of weak handle
// in most of the cases would lead to memory leak.
- ASSERT(state() != NEAR_DEATH);
+ CHECK(state() != NEAR_DEATH);
return true;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
