C:\Node\v8-git>git cl upload
Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit upload checks ...
C:\Node\v8-git\src\allocation-site-scopes.h:46: You don't need a ; after a
} [readability/braces]
[4]
Done processing C:\Node\v8-git\src\allocation-site-scopes.h
C:\Node\v8-git\src\regexp-macro-assembler-tracer.cc:217: You don't need a
; after a } [readability
/braces] [4]
Done processing C:\Node\v8-git\src\regexp-macro-assembler-tracer.cc
C:\Node\v8-git\src\d8-posix.cc:109: Is this a non-const reference? If so,
make const or use a point
er: struct timeval& start_time [runtime/references] [2]
C:\Node\v8-git\src\d8-posix.cc:275: Is this a non-const reference? If so,
make const or use a point
er: ExecArgs& exec_args [runtime/references] [2]
C:\Node\v8-git\src\d8-posix.cc:314: Is this a non-const reference? If so,
make const or use a point
er: struct timeval& start_time [runtime/references] [2]
C:\Node\v8-git\src\d8-posix.cc:386: Is this a non-const reference? If so,
make const or use a point
er: ZombieProtector& child_waiter [runtime/references] [2]
C:\Node\v8-git\src\d8-posix.cc:387: Is this a non-const reference? If so,
make const or use a point
er: struct timeval& start_time [runtime/references] [2]
Done processing C:\Node\v8-git\src\d8-posix.cc
C:\Node\v8-git\src\counters.h:307: You don't need a ; after a }
[readability/braces] [4]
Done processing C:\Node\v8-git\src\counters.h
C:\Node\v8-git\src\full-codegen.h:237: You don't need a ; after a }
[readability/braces] [4]
Done processing C:\Node\v8-git\src\full-codegen.h
C:\Node\v8-git\src\liveedit.cc:1844: Is this a non-const reference? If so,
make const or use a poin
ter: TARGET& target [runtime/references] [2]
Done processing C:\Node\v8-git\src\liveedit.cc
C:\Node\v8-git\src\stub-cache.cc:328: Is this a non-const reference? If
so, make const or use a poi
nter: CompareNilICStub& stub [runtime/references] [2]
Done processing C:\Node\v8-git\src\stub-cache.cc
C:\Node\v8-git\src\a64\cpu-a64.h:52: You don't need a ; after a }
[readability/braces] [4]
Done processing C:\Node\v8-git\src\a64\cpu-a64.h
C:\Node\v8-git\src\stub-cache.h:118: Is this a non-const reference? If so,
make const or use a poin
ter: CompareNilICStub& stub [runtime/references] [2]
Done processing C:\Node\v8-git\src\stub-cache.h
C:\Node\v8-git\src\elements.cc:138: public: should be indented +1 space
inside class ElementsKindTr
aits [whitespace/indent] [3]
Done processing C:\Node\v8-git\src\elements.cc
C:\Node\v8-git\src\heap.h:3058: Is this a non-const reference? If so, make
const or use a pointer:
kHeapObjectTag & kNotMarkedBit [runtime/references] [2]
Done processing C:\Node\v8-git\src\heap.h
C:\Node\v8-git\src\arm\constants-arm.h:136: You don't need a ; after a }
[readability/braces] [4]
Done processing C:\Node\v8-git\src\arm\constants-arm.h
C:\Node\v8-git\src\a64\constants-a64.h:307: You don't need a ; after a }
[readability/braces] [4]
Done processing C:\Node\v8-git\src\a64\constants-a64.h
C:\Node\v8-git\src\a64\lithium-a64.h:1453: Is this a non-const reference?
If so, make const or use
a pointer: ZoneList<LOperand*>& operands [runtime/references] [2]
C:\Node\v8-git\src\a64\lithium-a64.h:2285: You don't need a ; after a }
[readability/braces] [4]
C:\Node\v8-git\src\a64\lithium-a64.h:2299: You don't need a ; after a }
[readability/braces] [4]
C:\Node\v8-git\src\a64\lithium-a64.h:2313: You don't need a ; after a }
[readability/braces] [4]
Done processing C:\Node\v8-git\src\a64\lithium-a64.h
C:\Node\v8-git\src\arm\lithium-arm.h:1762: Is this a non-const reference?
If so, make const or use
a pointer: ZoneList<LOperand*>& operands [runtime/references] [2]
Done processing C:\Node\v8-git\src\arm\lithium-arm.h
C:\Node\v8-git\src\ia32\assembler-ia32.h:334: You don't need a ; after a }
[readability/braces] [4
]
Done processing C:\Node\v8-git\src\ia32\assembler-ia32.h
C:\Node\v8-git\src\arm\simulator-arm.cc:720: Consider using CHECK_EQ
instead of CHECK(a == b) [rea
dability/check] [2]
Done processing C:\Node\v8-git\src\arm\simulator-arm.cc
C:\Node\v8-git\src\mips\assembler-mips.cc:276: Is this a non-const
reference? If so, make const or
use a pointer: kPointerSize & kImm16Mask [runtime/references] [2]
C:\Node\v8-git\src\mips\assembler-mips.cc:279: Is this a non-const
reference? If so, make const or
use a pointer: kPointerSize & kImm16Mask [runtime/references] [2]
C:\Node\v8-git\src\mips\assembler-mips.cc:282: Is this a non-const
reference? If so, make const or
use a pointer: 0 & kImm16Mask [runtime/references] [2]
C:\Node\v8-git\src\mips\assembler-mips.cc:285: Is this a non-const
reference? If so, make const or
use a pointer: 0 & kImm16Mask [runtime/references] [2]
C:\Node\v8-git\src\mips\assembler-mips.cc:288: Is this a non-const
reference? If so, make const or
use a pointer: 0 & kImm16Mask [runtime/references] [2]
C:\Node\v8-git\src\mips\assembler-mips.cc:291: Is this a non-const
reference? If so, make const or
use a pointer: 0 & kImm16Mask [runtime/references] [2]
C:\Node\v8-git\src\mips\assembler-mips.cc:294: Is this a non-const
reference? If so, make const or
use a pointer: kNegOffset & kImm16Mask [runtime/references] [2]
C:\Node\v8-git\src\mips\assembler-mips.cc:297: Is this a non-const
reference? If so, make const or
use a pointer: kNegOffset & kImm16Mask [runtime/references] [2]
Done processing C:\Node\v8-git\src\mips\assembler-mips.cc
C:\Node\v8-git\src\arm\simulator-arm.h:291: You don't need a ; after a }
[readability/braces] [4]
Done processing C:\Node\v8-git\src\arm\simulator-arm.h
C:\Node\v8-git\src\mips\constants-mips.cc:190: You don't need a ; after a
} [readability/braces] [
4]
C:\Node\v8-git\src\mips\constants-mips.cc:177: You don't need a ; after a
} [readability/braces] [
4]
C:\Node\v8-git\src\mips\constants-mips.cc:186: You don't need a ; after a
} [readability/braces] [
4]
C:\Node\v8-git\src\mips\constants-mips.cc:216: You don't need a ; after a
} [readability/braces] [
4]
C:\Node\v8-git\src\mips\constants-mips.cc:206: You don't need a ; after a
} [readability/braces] [
4]
C:\Node\v8-git\src\mips\constants-mips.cc:213: You don't need a ; after a
} [readability/braces] [
4]
C:\Node\v8-git\src\mips\constants-mips.cc:235: You don't need a ; after a
} [readability/braces] [
4]
C:\Node\v8-git\src\mips\constants-mips.cc:352: You don't need a ; after a
} [readability/braces] [
4]
C:\Node\v8-git\src\mips\constants-mips.cc:281: You don't need a ; after a
} [readability/braces] [
4]
C:\Node\v8-git\src\mips\constants-mips.cc:290: You don't need a ; after a
} [readability/braces] [
4]
C:\Node\v8-git\src\mips\constants-mips.cc:299: You don't need a ; after a
} [readability/braces] [
4]
C:\Node\v8-git\src\mips\constants-mips.cc:307: You don't need a ; after a
} [readability/braces] [
4]
Done processing C:\Node\v8-git\src\mips\constants-mips.cc
C:\Node\v8-git\src\jsregexp.cc:1228: Is this a non-const reference? If so,
make const or use a poin
ter: OutSet& registers_to_pop [runtime/references] [2]
C:\Node\v8-git\src\jsregexp.cc:1229: Is this a non-const reference? If so,
make const or use a poin
ter: OutSet& registers_to_clear [runtime/references] [2]
C:\Node\v8-git\src\jsregexp.cc:1245: Is this a non-const reference? If so,
make const or use a poin
ter: OutSet& affected_registers [runtime/references] [2]
Done processing C:\Node\v8-git\src\jsregexp.cc
C:\Node\v8-git\src\mips\assembler-mips.h:866: private: should be indented
+1 space inside class Blo
ckGrowBufferScope [whitespace/indent] [3]
Done processing C:\Node\v8-git\src\mips\assembler-mips.h
C:\Node\v8-git\src\mips\constants-mips.h:529: You don't need a ; after a }
[readability/braces] [4
]
Done processing C:\Node\v8-git\src\mips\constants-mips.h
C:\Node\v8-git\src\mips\disasm-mips.cc:303: You don't need a ; after a }
[readability/braces] [4]
C:\Node\v8-git\src\mips\disasm-mips.cc:433: You don't need a ; after a }
[readability/braces] [4]
C:\Node\v8-git\src\mips\disasm-mips.cc:629: You don't need a ; after a }
[readability/braces] [4]
C:\Node\v8-git\src\mips\disasm-mips.cc:935: You don't need a ; after a }
[readability/braces] [4]
C:\Node\v8-git\src\mips\disasm-mips.cc:822: You don't need a ; after a }
[readability/braces] [4]
Done processing C:\Node\v8-git\src\mips\disasm-mips.cc
C:\Node\v8-git\src\ia32\lithium-ia32.h:1765: Is this a non-const
reference? If so, make const or us
e a pointer: ZoneList<LOperand*>& operands [runtime/references] [2]
Done processing C:\Node\v8-git\src\ia32\lithium-ia32.h
C:\Node\v8-git\src\mips\lithium-codegen-mips.h:344: Is this a non-const
reference? If so, make cons
t or use a pointer: Register& cmp1 [runtime/references] [2]
C:\Node\v8-git\src\mips\lithium-codegen-mips.h:345: Is this a non-const
reference? If so, make cons
t or use a pointer: Operand& cmp2 [runtime/references] [2]
Done processing C:\Node\v8-git\src\mips\lithium-codegen-mips.h
C:\Node\v8-git\src\objects-inl.h:2995: Is this a non-const reference? If
so, make const or use a po
inter: Visitor& visitor [runtime/references] [2]
C:\Node\v8-git\src\objects-inl.h:2996: Is this a non-const reference? If
so, make const or use a po
inter: ConsOp& cons_op [runtime/references] [2]
Done processing C:\Node\v8-git\src\objects-inl.h
C:\Node\v8-git\src\jsregexp.h:1488: Is this a non-const reference? If so,
make const or use a point
er: OutSet& affected_registers [runtime/references] [2]
C:\Node\v8-git\src\jsregexp.h:1494: Is this a non-const reference? If so,
make const or use a point
er: OutSet& registers_to_pop [runtime/references] [2]
C:\Node\v8-git\src\jsregexp.h:1495: Is this a non-const reference? If so,
make const or use a point
er: OutSet& registers_to_clear [runtime/references] [2]
Done processing C:\Node\v8-git\src\jsregexp.h
C:\Node\v8-git\src\objects.h:624: Is this a non-const reference? If so,
make const or use a pointer
: kSeqStringTag & kIsIndirectStringMask [runtime/references] [2]
C:\Node\v8-git\src\objects.h:625: Is this a non-const reference? If so,
make const or use a pointer
: kExternalStringTag & kIsIndirectStringMask [runtime/references] [2]
C:\Node\v8-git\src\objects.h:627: Is this a non-const reference? If so,
make const or use a pointer
: kConsStringTag & kIsIndirectStringMask [runtime/references] [2]
C:\Node\v8-git\src\objects.h:629: Is this a non-const reference? If so,
make const or use a pointer
: kSlicedStringTag & kIsIndirectStringMask [runtime/references] [2]
C:\Node\v8-git\src\objects.h:4966: public: should be indented +1 space
inside class Type [whitespa
ce/indent] [3]
C:\Node\v8-git\src\objects.h:8959: Is this a non-const reference? If so,
make const or use a pointe
r: Visitor& visitor [runtime/references] [2]
C:\Node\v8-git\src\objects.h:8960: Is this a non-const reference? If so,
make const or use a pointe
r: ConsOp& cons_op [runtime/references] [2]
Done processing C:\Node\v8-git\src\objects.h
C:\Node\v8-git\src\mips\simulator-mips.cc:866: Consider using CHECK_EQ
instead of CHECK(a == b) [r
eadability/check] [2]
C:\Node\v8-git\src\mips\simulator-mips.cc:1728: Is this a non-const
reference? If so, make const or
use a pointer: int32_t& alu_out [runtime/references] [2]
C:\Node\v8-git\src\mips\simulator-mips.cc:1729: Is this a non-const
reference? If so, make const or
use a pointer: int64_t& i64hilo [runtime/references] [2]
C:\Node\v8-git\src\mips\simulator-mips.cc:1730: Is this a non-const
reference? If so, make const or
use a pointer: uint64_t& u64hilo [runtime/references] [2]
C:\Node\v8-git\src\mips\simulator-mips.cc:1731: Is this a non-const
reference? If so, make const or
use a pointer: int32_t& next_pc [runtime/references] [2]
C:\Node\v8-git\src\mips\simulator-mips.cc:1732: Is this a non-const
reference? If so, make const or
use a pointer: int32_t& return_addr_reg [runtime/references] [2]
C:\Node\v8-git\src\mips\simulator-mips.cc:1733: Is this a non-const
reference? If so, make const or
use a pointer: bool& do_interrupt [runtime/references] [2]
C:\Node\v8-git\src\mips\simulator-mips.cc:1967: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:1784: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:1921: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:1937: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:1963: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:2375: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:2248: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:2226: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:2261: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:2342: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:2368: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:2607: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:2436: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:2455: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:2474: You don't need a ; after a
} [readability/braces]
[4]
C:\Node\v8-git\src\mips\simulator-mips.cc:2683: You don't need a ; after a
} [readability/braces]
[4]
Done processing C:\Node\v8-git\src\mips\simulator-mips.cc
C:\Node\v8-git\src\hydrogen-instructions.h:2313: Is this a non-const
reference? If so, make const o
r use a pointer: Vector<HValue*>& operands [runtime/references] [2]
C:\Node\v8-git\src\hydrogen-instructions.h:2366: Is this a non-const
reference? If so, make const o
r use a pointer: Vector<HValue*>& operands [runtime/references] [2]
C:\Node\v8-git\src\hydrogen-instructions.h:6253: You don't need a ; after
a } [readability/braces]
[4]
Done processing C:\Node\v8-git\src\hydrogen-instructions.h
C:\Node\v8-git\src\x64\assembler-x64.h:350: You don't need a ; after a }
[readability/braces] [4]
Done processing C:\Node\v8-git\src\x64\assembler-x64.h
C:\Node\v8-git\src\mips\simulator-mips.h:292: Is this a non-const
reference? If so, make const or u
se a pointer: int32_t& alu_out [runtime/references] [2]
C:\Node\v8-git\src\mips\simulator-mips.h:293: Is this a non-const
reference? If so, make const or u
se a pointer: int64_t& i64hilo [runtime/references] [2]
C:\Node\v8-git\src\mips\simulator-mips.h:294: Is this a non-const
reference? If so, make const or u
se a pointer: uint64_t& u64hilo [runtime/references] [2]
C:\Node\v8-git\src\mips\simulator-mips.h:295: Is this a non-const
reference? If so, make const or u
se a pointer: int32_t& next_pc [runtime/references] [2]
C:\Node\v8-git\src\mips\simulator-mips.h:296: Is this a non-const
reference? If so, make const or u
se a pointer: int32_t& return_addr_reg [runtime/references] [2]
C:\Node\v8-git\src\mips\simulator-mips.h:297: Is this a non-const
reference? If so, make const or u
se a pointer: bool& do_interrupt [runtime/references] [2]
Done processing C:\Node\v8-git\src\mips\simulator-mips.h
C:\Node\v8-git\src\mips\macro-assembler-mips.cc:1219: You don't need a ;
after a } [readability/br
aces] [4]
Done processing C:\Node\v8-git\src\mips\macro-assembler-mips.cc
C:\Node\v8-git\src\mips\lithium-mips.h:1740: Is this a non-const
reference? If so, make const or us
e a pointer: ZoneList<LOperand*>& operands [runtime/references] [2]
Done processing C:\Node\v8-git\src\mips\lithium-mips.h
C:\Node\v8-git\src\mips\lithium-codegen-mips.cc:5399: Is this a non-const
reference? If so, make co
nst or use a pointer: Register& cmp1 [runtime/references] [2]
C:\Node\v8-git\src\mips\lithium-codegen-mips.cc:5400: Is this a non-const
reference? If so, make co
nst or use a pointer: Operand& cmp2 [runtime/references] [2]
Done processing C:\Node\v8-git\src\mips\lithium-codegen-mips.cc
C:\Node\v8-git\test\cctest\test-spaces.cc:397: You don't need a ; after a
} [readability/braces] [
4]
Done processing C:\Node\v8-git\test\cctest\test-spaces.cc
C:\Node\v8-git\src\mips\macro-assembler-mips.h:760: You don't need a ;
after a } [readability/brac
es] [4]
Done processing C:\Node\v8-git\src\mips\macro-assembler-mips.h
C:\Node\v8-git\src\parser.cc:3701: You don't need a ; after a }
[readability/braces] [4]
Done processing C:\Node\v8-git\src\parser.cc
C:\Node\v8-git\src\x64\lithium-x64.h:1709: Is this a non-const reference?
If so, make const or use
a pointer: ZoneList<LOperand*>& operands [runtime/references] [2]
Done processing C:\Node\v8-git\src\x64\lithium-x64.h
C:\Node\v8-git\src\heap.cc:2130: Is this a non-const reference? If so,
make const or use a pointer:
FixedDoubleArray::kHeaderSize & kDoubleAlignmentMask [runtime/references]
[2]
C:\Node\v8-git\src\heap.cc:2131: Is this a non-const reference? If so,
make const or use a pointer:
ConstantPoolArray::kHeaderSize & kDoubleAlignmentMask
[runtime/references] [2]
Done processing C:\Node\v8-git\src\heap.cc
C:\Node\v8-git\include\v8.h:5284: You don't need a ; after a }
[readability/braces] [4]
Done processing C:\Node\v8-git\include\v8.h
C:\Node\v8-git\samples\process.cc:577: Is this a non-const reference? If
so, make const or use a po
inter: map<string, string>& options [runtime/references] [2]
Done processing C:\Node\v8-git\samples\process.cc
C:\Node\v8-git\test\cctest\test-api.cc:7831: Is this a non-const
reference? If so, make const or us
e a pointer: LocalContext& context [runtime/references] [2]
C:\Node\v8-git\test\cctest\test-api.cc:7858: Is this a non-const
reference? If so, make const or us
e a pointer: LocalContext& context [runtime/references] [2]
C:\Node\v8-git\test\cctest\test-api.cc:21958: public: should be indented
+1 space inside class ApiC
allOptimizationChecker [whitespace/indent] [3]
Done processing C:\Node\v8-git\test\cctest\test-api.cc
C:\Node\v8-git\test\cctest\test-semaphore.cc:40: public: should be
indented +1 space inside class W
aitAndSignalThread [whitespace/indent] [3]
C:\Node\v8-git\test\cctest\test-semaphore.cc:55: private: should be
indented +1 space inside class
WaitAndSignalThread [whitespace/indent] [3]
C:\Node\v8-git\test\cctest\test-semaphore.cc:118: public: should be
indented +1 space inside class
ProducerThread [whitespace/indent] [3]
C:\Node\v8-git\test\cctest\test-semaphore.cc:133: public: should be
indented +1 space inside class
ConsumerThread [whitespace/indent] [3]
Done processing C:\Node\v8-git\test\cctest\test-semaphore.cc
Total errors found: 122
Total violating files: 0
** Presubmit Messages **
Missing OWNER reviewers for these files:
src\bootstrapper.cc
src\isolate.h
Suggested OWNERS: (Use "git-cl owners" to interactively select owners.)
[email protected]
** Presubmit ERRORS **
C++ lint check failed
Presubmit checks took 20.1s to calculate.
On Monday, February 24, 2014 2:16:07 PM UTC+1, Dmitry Lomov wrote:
>
> [-v8-dev,+v8-users]
> What are the errors that the tool reports? (Devs on the team see no errors
> from presubmit script)
>
> Thanks,
> Dmitry
>
>
> On Mon, Feb 24, 2014 at 2:13 PM, Alexis Campailla
> <[email protected]<javascript:>
> > wrote:
>
>> I am trying to upload a patch for the first time. I just checked out a
>> fresh copy of the master branch using Git. I followed these instructions:
>> https://code.google.com/p/v8/wiki/UsingGit and then applied my small
>> change in a new branch.
>>
>>
>>
>> When trying to upload the patch with git cl upload, the presubmit checks
>> fail and the patch doesn’t get uploaded.
>>
>>
>>
>> The tool is complaining about 122 errors in C++ lint checks. I did not
>> however touch these files. What am I doing wrong?
>>
>>
>>
>> Thanks in advance.
>>
>>
>>
>> Total errors found: 122
>>
>> Total violating files: 0
>>
>>
>>
>> ** Presubmit Messages **
>>
>> Missing OWNER reviewers for these files:
>>
>> src\bootstrapper.cc
>>
>> src\isolate.h
>>
>>
>>
>> Suggested OWNERS: (Use "git-cl owners" to interactively select owners.)
>>
>> …@chromium.org
>>
>>
>>
>> ** Presubmit ERRORS **
>>
>> C++ lint check failed
>>
>> --
>> --
>> v8-dev mailing list
>> [email protected] <javascript:>
>> http://groups.google.com/group/v8-dev
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "v8-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [email protected] <javascript:>.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>
>
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
