Revision: 19549
Author: [email protected]
Date: Tue Feb 25 16:33:54 2014 UTC
Log: Fix for failing asserts in HBoundsCheck code generation on x64:
index register should be zero extended.
BUG=345820
LOG=N
[email protected]
Review URL: https://codereview.chromium.org/180013002
http://code.google.com/p/v8/source/detail?r=19549
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-crbug-345820.js
Modified:
/branches/bleeding_edge/src/x64/disasm-x64.cc
/branches/bleeding_edge/src/x64/lithium-gap-resolver-x64.cc
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-crbug-345820.js
Tue Feb 25 16:33:54 2014 UTC
@@ -0,0 +1,18 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax --debug-code
+
+var __v_6 = {};
+__v_6 = new Int32Array(5);
+for (var i = 0; i < __v_6.length; i++) __v_6[i] = 0;
+
+function __f_7(N) {
+ for (var i = -1; i < N; i++) {
+ __v_6[i] = i;
+ }
+}
+__f_7(1);
+%OptimizeFunctionOnNextCall(__f_7);
+__f_7(__v_6.length);
=======================================
--- /branches/bleeding_edge/src/x64/disasm-x64.cc Wed Feb 19 13:51:49 2014
UTC
+++ /branches/bleeding_edge/src/x64/disasm-x64.cc Tue Feb 25 16:33:54 2014
UTC
@@ -1459,7 +1459,8 @@
data += 3;
break;
case OPERAND_DOUBLEWORD_SIZE:
- addr = reinterpret_cast<byte*>(*reinterpret_cast<int32_t*>(data
+ 1));
+ addr =
+ reinterpret_cast<byte*>(*reinterpret_cast<uint32_t*>(data +
1));
data += 5;
break;
case OPERAND_QUADWORD_SIZE:
=======================================
--- /branches/bleeding_edge/src/x64/lithium-gap-resolver-x64.cc Mon Jan 20
04:59:40 2014 UTC
+++ /branches/bleeding_edge/src/x64/lithium-gap-resolver-x64.cc Tue Feb 25
16:33:54 2014 UTC
@@ -198,7 +198,7 @@
if (cgen_->IsSmiConstant(constant_source)) {
__ Move(dst, cgen_->ToSmi(constant_source));
} else if (cgen_->IsInteger32Constant(constant_source)) {
- __ Set(dst, cgen_->ToInteger32(constant_source));
+ __ Set(dst,
static_cast<uint32_t>(cgen_->ToInteger32(constant_source)));
} else {
__ Move(dst, cgen_->ToHandle(constant_source));
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
