Hi Hannes, no I didn't delete any patch set?
Here were my comments from last week.
In general, I kept the refactoring "small." See if that is okay with you and
then I could follow up with changes that bring something like
HAllocationMode to
heap.h.
Thanks,
--Michael
https://codereview.chromium.org/170703002/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/170703002/diff/1/src/heap.h#newcode688
src/heap.h:688: // pretenure state.
On 2014/02/19 21:29:07, Hannes Payer wrote:
What do you mean by "does not influence the pretenure state"?
I mean that the AllocationSite is not mined for information used to
determine the Space for the allocation.
Perhaps there should be some renaming of these methods. The way they
function is that a site is passed only so that a memento can be
allocated with the object. Maybe the argument should be called
"site_for_memento."
https://codereview.chromium.org/170703002/diff/1/src/heap.h#newcode693
src/heap.h:693: AllocationSite* allocation_site = NULL);
On 2014/02/19 21:29:07, Hannes Payer wrote:
Why did you get rid of the Handle?
Because it's not a handlefied method and the other arguments to the
method are pointers. The use of a handle was asymmetrical, and sends a
contradictory message to the "raw" MaybeObject* style of the method.
https://codereview.chromium.org/170703002/diff/1/src/heap.h#newcode693
src/heap.h:693: AllocationSite* allocation_site = NULL);
On 2014/02/19 21:29:07, Hannes Payer wrote:
What about implementing an AllocationMode, similar to HAllocationMode?
I am thinking small with this CL, focused on eliminating duplicate code
rather than introducing new constructs.
https://codereview.chromium.org/170703002/diff/1/src/heap.h#newcode774
src/heap.h:774: // points to the site. It doesn't influence pretenure
state.
On 2014/02/19 21:29:07, Hannes Payer wrote:
same comments as above
Indeed. And probably the fact that I have to explain this
(unsuccessfully at that) implies that the API is broken anyway!
https://codereview.chromium.org/170703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
