Reviewers: Sven Panne, ulan,
Description:
Delete the simulator when we don't need it anymore
BUG=none
[email protected],[email protected]
LOG=n
Please review this at https://codereview.chromium.org/180243010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+16, -0 lines):
M src/arm/simulator-arm.cc
M src/isolate.h
M src/isolate.cc
M src/mips/simulator-mips.cc
Index: src/arm/simulator-arm.cc
diff --git a/src/arm/simulator-arm.cc b/src/arm/simulator-arm.cc
index
ac36687fcabe13209c2311a4973d611845ae41c4..a7fccddc96b63b085d3ad7a228c5ef4ae381b483
100644
--- a/src/arm/simulator-arm.cc
+++ b/src/arm/simulator-arm.cc
@@ -796,6 +796,10 @@ Simulator::Simulator(Isolate* isolate) :
isolate_(isolate) {
}
+Simulator::~Simulator() {
+}
+
+
// When the generated code calls an external reference we need to catch
that in
// the simulator. The external reference will be a function compiled for
the
// host architecture. We need to call that function instead of trying to
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index
d81e50e2235399bec8a10a9eaa925f027b93c3c8..9b7c7dc33ed1e103a7a2adeb35e590d4e92e6e61
100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1463,6 +1463,13 @@ Isolate::ThreadDataTable::~ThreadDataTable() {
}
+Isolate::PerIsolateThreadData::~PerIsolateThreadData() {
+#if defined(USE_SIMULATOR)
+ delete simulator_;
+#endif
+}
+
+
Isolate::PerIsolateThreadData*
Isolate::ThreadDataTable::Lookup(Isolate* isolate,
ThreadId thread_id) {
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index
ef1dd30b227b1ec9a263d27c85ce1ec940715b32..897197bc75eb240474bbb6c110bb625245fda0be
100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -396,6 +396,7 @@ class Isolate {
#endif
next_(NULL),
prev_(NULL) { }
+ ~PerIsolateThreadData();
Isolate* isolate() const { return isolate_; }
ThreadId thread_id() const { return thread_id_; }
Index: src/mips/simulator-mips.cc
diff --git a/src/mips/simulator-mips.cc b/src/mips/simulator-mips.cc
index
efce887c2e6d4e5f7ef21e07246b1118114ec6de..d26499bbc5db087fd8ac6c4597a2412a2173290c
100644
--- a/src/mips/simulator-mips.cc
+++ b/src/mips/simulator-mips.cc
@@ -925,6 +925,10 @@ Simulator::Simulator(Isolate* isolate) :
isolate_(isolate) {
}
+Simulator::~Simulator() {
+}
+
+
// When the generated code calls an external reference we need to catch
that in
// the simulator. The external reference will be a function compiled for
the
// host architecture. We need to call that function instead of trying to
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
