Revision: 19560
Author: [email protected]
Date: Wed Feb 26 11:54:55 2014 UTC
Log: A64: Decoder should not inherit from DecoderVisitor
BUG=none
[email protected], [email protected]
LOG=n
Review URL: https://codereview.chromium.org/177073013
http://code.google.com/p/v8/source/detail?r=19560
Modified:
/branches/bleeding_edge/src/a64/decoder-a64.h
=======================================
--- /branches/bleeding_edge/src/a64/decoder-a64.h Wed Feb 12 09:19:30 2014
UTC
+++ /branches/bleeding_edge/src/a64/decoder-a64.h Wed Feb 26 11:54:55 2014
UTC
@@ -89,23 +89,17 @@
// must provide implementations for all of these functions.
class DecoderVisitor {
public:
+ virtual ~DecoderVisitor() {}
+
#define DECLARE(A) virtual void Visit##A(Instruction* instr) = 0;
VISITOR_LIST(DECLARE)
#undef DECLARE
-
- virtual ~DecoderVisitor() {}
-
- private:
- // Visitors are registered in a list.
- std::list<DecoderVisitor*> visitors_;
-
- friend class Decoder;
};
-class Decoder: public DecoderVisitor {
+class Decoder {
public:
- explicit Decoder() {}
+ Decoder() {}
// Top-level instruction decoder function. Decodes an instruction and
calls
// the visitor functions registered with the Decoder class.
@@ -194,6 +188,9 @@
// tree, and call the corresponding visitors.
// On entry, instruction bits 27:25 = 0x7.
void DecodeAdvSIMDDataProcessing(Instruction* instr);
+
+ // Visitors are registered in a list.
+ std::list<DecoderVisitor*> visitors_;
};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
