LGTM with nits.
https://codereview.chromium.org/181053005/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/181053005/diff/1/src/arm/lithium-codegen-arm.cc#newcode4651
src/arm/lithium-codegen-arm.cc:4651: void
LCodeGen::DoDeferredNumberTagI(LInstruction* instr,
Not really part of this CL, but can we rename this to
DoDeferredNumberTag or DoDeferredNumberTagIU? As it is, the name is
misleading.
https://codereview.chromium.org/181053005/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/181053005/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode4949
src/ia32/lithium-codegen-ia32.cc:4949: void
LCodeGen::DoDeferredNumberTagI(LInstruction* instr,
Same here.
https://codereview.chromium.org/181053005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
