LGTM with nits.
https://codereview.chromium.org/177293009/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/177293009/diff/1/src/deoptimizer.cc#newcode3051
src/deoptimizer.cc:3051: CHECK(false); // We should never get here
nit: Let's use FATAL() with a short message instead.
https://codereview.chromium.org/177293009/diff/1/src/deoptimizer.cc#newcode3186
src/deoptimizer.cc:3186: CHECK(false); // We should never get here
nit: Likewise.
https://codereview.chromium.org/177293009/diff/1/src/deoptimizer.cc#newcode3257
src/deoptimizer.cc:3257: Handle<Object>
undefined(isolate->heap()->undefined_value(), isolate);
nit: Use isolate->factory()->undefined_value() instead of a new handle.
https://codereview.chromium.org/177293009/diff/1/src/deoptimizer.cc#newcode3336
src/deoptimizer.cc:3336: CHECK(false); // We should never get here
nit: Likewise.
https://codereview.chromium.org/177293009/diff/1/test/mjsunit/regress/regress-347262.js
File test/mjsunit/regress/regress-347262.js (right):
https://codereview.chromium.org/177293009/diff/1/test/mjsunit/regress/regress-347262.js#newcode61
test/mjsunit/regress/regress-347262.js:61: assertEquals(3, (f(0)));
nit: Obsolete parens around f(0) here.
https://codereview.chromium.org/177293009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
