Reviewers: rossberg,
Message:
Please PTAL and push to commit queue if LGTM.
Description:
Runtime::RunMicrotask should silent return if no pending microtask work
(rather
than asserting)
R=rossberg
BUG=347532
Please review this at https://codereview.chromium.org/181013008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -4 lines):
M src/runtime.cc
M test/mjsunit/fuzz-natives-part3.js
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
306042f4ea65601e0e4ed3c5fe57ee08937be87c..ba21345aefd65b99f04220f00b46d78e5e17194a
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -14685,7 +14685,8 @@ RUNTIME_FUNCTION(MaybeObject*,
Runtime_SetMicrotaskPending) {
RUNTIME_FUNCTION(MaybeObject*, Runtime_RunMicrotasks) {
HandleScope scope(isolate);
ASSERT(args.length() == 0);
- Execution::RunMicrotasks(isolate);
+ if (isolate->microtask_pending())
+ Execution::RunMicrotasks(isolate);
return isolate->heap()->undefined_value();
}
Index: test/mjsunit/fuzz-natives-part3.js
diff --git a/test/mjsunit/fuzz-natives-part3.js
b/test/mjsunit/fuzz-natives-part3.js
index
b3a1fb610c7c897524f428ae8ca4b1081537785a..1f33cef00e6c7799d7a04eba508546d138e101db
100644
--- a/test/mjsunit/fuzz-natives-part3.js
+++ b/test/mjsunit/fuzz-natives-part3.js
@@ -217,9 +217,6 @@ var knownProblems = {
"DataViewGetBuffer": true,
"DataViewGetByteLength": true,
"DataViewGetByteOffset": true,
-
- // Only ever called internally.
- "RunMicrotasks": true
};
var currentlyUncallable = {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
