Reviewers: jochen (OOO from March 1),
Message:
Jochen, is this the right fix?
Description:
Fix r19564: Don't free decoder_ in ~Simulator().
The simulator never allocates decoder_, and it is always passed from the
calling scope (if set at all). The caller should be responsible for
deleting it.
This fixes the failures in test-assembler-a64.cc.
BUG=
Please review this at https://codereview.chromium.org/183203004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -1 lines):
M src/a64/simulator-a64.cc
Index: src/a64/simulator-a64.cc
diff --git a/src/a64/simulator-a64.cc b/src/a64/simulator-a64.cc
index
1ae0bf01a480181c0bd30e1a1f8b09e984930948..66ff8327e76aebfd79e762277c0886a9f3da8376
100644
--- a/src/a64/simulator-a64.cc
+++ b/src/a64/simulator-a64.cc
@@ -424,7 +424,6 @@ Simulator::~Simulator() {
delete disassembler_decoder_;
delete print_disasm_;
DeleteArray(last_debugger_input_);
- delete decoder_;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
