Reviewers: Yang,
Description:
Removed bogus ASSERT.
LOG=y
BUG=347542
Please review this at https://codereview.chromium.org/183763007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -7 lines):
M src/runtime.cc
A + test/mjsunit/regress/regress-347542.js
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
8a1946efbfeb88b695abfc25647e55c8c24b58a3..0caaa47bd57f79ba52b8b46959a590c9fe918041
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -8620,7 +8620,6 @@ RUNTIME_FUNCTION(MaybeObject*,
Runtime_NeverOptimizeFunction) {
HandleScope scope(isolate);
ASSERT(args.length() == 1);
CONVERT_ARG_CHECKED(JSFunction, function, 0);
- ASSERT(!function->IsOptimized());
function->shared()->set_optimization_disabled(true);
return isolate->heap()->undefined_value();
}
Index: test/mjsunit/regress/regress-347542.js
diff --git a/test/mjsunit/regress/regress-crbug-346141.js
b/test/mjsunit/regress/regress-347542.js
similarity index 56%
copy from test/mjsunit/regress/regress-crbug-346141.js
copy to test/mjsunit/regress/regress-347542.js
index
798b7704ec2cc0eb928966fdfe9f979d0fe51f94..901d798fb7fbea45f0d9f3d8ba6c7a9846bf6dd6
100644
--- a/test/mjsunit/regress/regress-crbug-346141.js
+++ b/test/mjsunit/regress/regress-347542.js
@@ -2,10 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Flags: --harmony-symbols
+// Flags: --allow-natives-syntax
-var s = Symbol()
-var o = {}
-o[s] = 2
-o[""] = 3
-Object.getOwnPropertySymbols(o)
+function foo() {}
+foo();
+%OptimizeFunctionOnNextCall(foo);
+foo();
+%NeverOptimizeFunction(foo);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
