Reviewers: titzer, Michael Starzinger,
Message:
PTAL, discovered this leak while investigating an unrelated crash.
WDYT about introducing weak_pointer_mode to visitors? If this is OK, then I
can
move other weak pointers under this check into the base visitor. This would
make
explicit which fields are weak and which are not.
Aliasing next_code_link to type_feedback_info is fragile. Maybe I should
rename
both fields to reflect aliasing or just add unalias them by adding another
field
to Code?
Description:
Fix memory leak caused by treating Code::next_code_link as strong in marker.
BUG=
TEST=test/cctest/NextCodeLinkIsWeak
Please review this at https://codereview.chromium.org/181833004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+100, -4 lines):
M src/heap.cc
M src/mark-compact.cc
M src/objects-visiting-inl.h
M src/objects-visiting.h
M src/objects.h
M test/cctest/test-heap.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
