Thanks Yang, addressed comments. Will check in after tree opens.
https://codereview.chromium.org/184103004/diff/20001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/184103004/diff/20001/src/code-stubs-hydrogen.cc#newcode1272
src/code-stubs-hydrogen.cc:1272: // slot iterator is pointing behind the
record we want to examine.
On 2014/03/03 08:27:02, Yang wrote:
This comment seems not to match the code...
if the slot iterator is indeed pointing behind the record we want to
examine,
wouldn't we need to use negative indices to load fields? The for-loop
in the
comment above suggests that we start at the last record, but then the
loop_builder is using kPostDecrement...
Right, the comment was old. I changed the loop iterator to point at the
*start* of each record we want to examine. Removing!
https://codereview.chromium.org/184103004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
