Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Fix symbol printing in migration / generalization tracing
BUG=
Please review this at https://codereview.chromium.org/176713006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -2 lines):
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
aa6e2808b46d283c5178cbff07f05da6db8ebdbd..94a80f7d7a2aea73db5b600c6c21fcb1d3d2218f
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -1576,7 +1576,12 @@ void Map::PrintGeneralization(FILE* file,
PrintF(file, "[generalizing ");
constructor_name()->PrintOn(file);
PrintF(file, "] ");
-
String::cast(instance_descriptors()->GetKey(modify_index))->PrintOn(file);
+ Name* name = instance_descriptors()->GetKey(modify_index);
+ if (name->IsString()) {
+ String::cast(name)->PrintOn(file);
+ } else {
+ PrintF(file, "{symbol %p}", static_cast<void*>(name));
+ }
if (constant_to_field) {
PrintF(file, ":c->f");
} else {
@@ -1616,7 +1621,7 @@ void JSObject::PrintInstanceMigration(FILE* file,
if (name->IsString()) {
String::cast(name)->PrintOn(file);
} else {
- PrintF(file, "???");
+ PrintF(file, "{symbol %p}", static_cast<void*>(name));
}
PrintF(file, " ");
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
