https://codereview.chromium.org/184923002/diff/80001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/184923002/diff/80001/src/objects.cc#newcode9641
src/objects.cc:9641: for (i = kEntriesStart; i < code_map->length(); i
+= kEntryLength) {
This code is relying on the code appearing only once in this optimized
code map, which is an invariant that should hold, but based on my
investigation, looks quite fragile.
Can we put an extra level of checking in this loop?
I.e. either go through the entire map and remove _all_ occurrences, or
assert there is only one.
I would prefer the former, since we have to loop over the entire array
anyway, even if we found it.
https://codereview.chromium.org/184923002/diff/80001/src/objects.cc#newcode9643
src/objects.cc:9643: if (Code::cast(code_map->get(i + 1)) ==
optimized_code) {
Please use kCachedCodeOffset here.
https://codereview.chromium.org/184923002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
