On 2014/03/03 12:24:14, ulan wrote:
PTAL. Most of the code is from r19603, but instead of checking for context
equality it now checks for code equality.
This addresses Ben's comments from
https://codereview.chromium.org/184923002:
> titzer 2014/03/03 12:02:44
> This code is relying on the code appearing only once in this optimized
code
map,
> which is an invariant that should hold, but based on my investigation,
looks
> quite fragile.
> Can we put an extra level of checking in this loop?
> I.e. either go through the entire map and remove _all_ occurrences, or
assert
> there is only one.
> I would prefer the former, since we have to loop over the entire array
anyway,
> even if we found it.
LGTM.
https://codereview.chromium.org/181493004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
