Reviewers: ulan, jochen (OOO until March 10),
Description:
A64: Handle a few TODOs.
Notes about a few TODOs handled in this patch:
* In ProfileEntryHookStub::Generate:
Stubs are always called with relocation.
* In CreateArrayDispatchOneArgument:
The branches to registers can't be conditional. We could use a jump
table,
but
there are only 6 different kinds so it is likely not worth it.
* In Builtins::Generate_StringConstructCode:
Rename the argc register (x0) after its meaning changes.
Remove a TODO: using a macro would not make the code clearer.
* In Generate_JSEntryTrampolineHelper:
Remove the TODO and raise an internal issue to investigate this.
* In Disassembler::SubstituteBranchTargetField:
Print the target address, but we don't have more info on the target.
Please review this at https://codereview.chromium.org/185793002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+52, -66 lines):
M src/a64/builtins-a64.cc
M src/a64/code-stubs-a64.cc
M src/a64/disasm-a64.cc
M src/a64/lithium-codegen-a64.cc
M test/cctest/test-disasm-a64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
