On 2014/03/04 10:23:14, ulan wrote:
Looks good overall, but I am not familiar with debug mirrors. Now that we
cache
results, can it happen that this keeps objects alive that would be dead
otherwise, i.e. can this cause a memory leak?

This is same as if the client code would cache these results on their side.

For example, in DevTools we would hold a funcMirror and a script, and then a
funcMirror.sourceLocation() call would again fetch the script from the V8
runtime.

Once we release the funcMirror - it's available to GC with all its cached
values.


https://codereview.chromium.org/184483004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to