Revision: 19647
Author: [email protected]
Date: Tue Mar 4 12:42:43 2014 UTC
Log: Don't disable hash randomization option in predictable mode.
We don't need it because
1) hash randomization uses random generator whose results depend on
--random-seed option which is set in predictable mode.
2) disabling hash randomization triggers assert in snapshot mode.
[email protected]
Review URL: https://codereview.chromium.org/171813015
http://code.google.com/p/v8/source/detail?r=19647
Modified:
/branches/bleeding_edge/src/flag-definitions.h
/branches/bleeding_edge/src/v8.cc
=======================================
--- /branches/bleeding_edge/src/flag-definitions.h Thu Feb 27 09:36:29 2014
UTC
+++ /branches/bleeding_edge/src/flag-definitions.h Tue Mar 4 12:42:43 2014
UTC
@@ -653,7 +653,6 @@
"Print the time it takes to lazily compile hydrogen code
stubs.")
DEFINE_bool(predictable, false, "enable predictable mode")
-DEFINE_neg_implication(predictable, randomize_hashes)
DEFINE_neg_implication(predictable, concurrent_recompilation)
DEFINE_neg_implication(predictable, concurrent_osr)
DEFINE_neg_implication(predictable, concurrent_sweeping)
=======================================
--- /branches/bleeding_edge/src/v8.cc Thu Feb 20 19:32:27 2014 UTC
+++ /branches/bleeding_edge/src/v8.cc Tue Mar 4 12:42:43 2014 UTC
@@ -187,12 +187,9 @@
void V8::InitializeOncePerProcessImpl() {
FlagList::EnforceFlagImplications();
- if (FLAG_predictable) {
- if (FLAG_random_seed == 0) {
- // Avoid random seeds in predictable mode.
- FLAG_random_seed = 12347;
- }
- FLAG_hash_seed = 0;
+ if (FLAG_predictable && FLAG_random_seed == 0) {
+ // Avoid random seeds in predictable mode.
+ FLAG_random_seed = 12347;
}
if (FLAG_stress_compaction) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
