Overall the approach is looking good. Need more test cases and investigate
why
performance drops. Possibly we need to avoid walking the entire transition
tree
on each descriptor generalization.
https://codereview.chromium.org/167303005/diff/70001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/167303005/diff/70001/src/flag-definitions.h#newcode240
src/flag-definitions.h:240: DEFINE_implication(track_field_types,
track_computed_fields)
I don't think you need computed_fields and double_fields.
https://codereview.chromium.org/167303005/diff/70001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/167303005/diff/70001/src/objects.cc#newcode2706
src/objects.cc:2706: next_descriptors->GetValue(i) !=
descriptors->GetValue(i)) break;
Please add a test for this case, ensuring that type feedback is properly
merged.
https://codereview.chromium.org/167303005/diff/70001/src/objects.cc#newcode8208
src/objects.cc:8208: }
As stated above: Please test these cases.
https://codereview.chromium.org/167303005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
