Reviewers: rossberg,
Message:
Note that simply setting the flag to true doesn't work because of
snapshotting
and enabling getting this working with snapshooting involved:
1) Moving the native functions out of experimental, which made the flag
pointless
2) Ensuring that no per-isolate state was allocated during the first pass of
object-observe.js (all is now lazily created).
https://codereview.chromium.org/183683022/diff/1/src/object-observe.js
File src/object-observe.js (left):
https://codereview.chromium.org/183683022/diff/1/src/object-observe.js#oldcode28
src/object-observe.js:28: "use strict";
it seems like all the built-in native js files are run as a single block
and so "use strict" causes errors elsewhere.
https://codereview.chromium.org/183683022/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (left):
https://codereview.chromium.org/183683022/diff/1/test/cctest/test-heap.cc#oldcode2035
test/cctest/test-heap.cc:2035: CHECK(proto->IsTheHole() ||
proto->IsJSObject());
It seems like the check for the hole here was actually wrong (would have
allow this test to pass if the storage *hadn't* been compacted.
https://codereview.chromium.org/183683022/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/183683022/diff/1/test/cctest/test-heap.cc#newcode2007
test/cctest/test-heap.cc:2007: CompileRun("var base = {};");
Note: the way this test was structured was asserting more than it needed
to. Specifically it was asserting that no built in created a prototype
transition, which struct me as a needless restriction on implementing
self-hosted code.
Description:
Enable Object.observe by default
R=rossberg
BUG=v8:2409
Please review this at https://codereview.chromium.org/183683022/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+209, -214 lines):
M src/accessors.cc
M src/bootstrapper.cc
M src/flag-definitions.h
M src/ic.cc
M src/object-observe.js
M src/objects.cc
M src/runtime.cc
M test/cctest/test-heap.cc
M test/cctest/test-microtask-delivery.cc
M test/cctest/test-object-observe.cc
M test/mjsunit/debug-script.js
M tools/gyp/v8.gyp
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
