Not really happy with the confusion of layers...
https://codereview.chromium.org/176843006/diff/40001/src/types.h
File src/types.h (right):
https://codereview.chromium.org/176843006/diff/40001/src/types.h#newcode144
src/types.h:144: V(TaggedPtr, -1 << 30 | kSemantic) /* MSB has
to be sign-extended */ \
On 2014/03/04 15:02:25, Michael Starzinger wrote:
I would be fine with this. If either Benedikt or Sven want this to be
handled
differently, then I defer to alternative suggestions from their end.
As already discussed yesterday, I consider this sign-extension here an
extremely ugly and confusing hack. We just want to stuff something which
the GC shouldn't care about into some kind of JavaScript value (a Smi,
but that't purely accidental here). We do similar things e.g. in the
exterrnal API, and I don't see why something similar to
DecodeSmiToAligned/EncodeAlignedAsSmi shouldn't work with the bit set at
hand. As it is, the current CL is mixing unrelated things together.
https://codereview.chromium.org/176843006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
