Quick DBCs...
https://codereview.chromium.org/186163002/diff/60001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/186163002/diff/60001/src/api.cc#newcode406
src/api.cc:406: isolate->set_event_logger(that);
This line is a *very* strong hint that SetEventLogger is in the wrong
class: It should be a normal member function within Isolate.
Furthermore, using EnterIsolateIfNeeded is a hack and should not be
used.
https://codereview.chromium.org/186163002/diff/60001/src/log.h
File src/log.h (right):
https://codereview.chromium.org/186163002/diff/60001/src/log.h#newcode104
src/log.h:104: (isolate)->event_logger()(name, 0)
Parenthesize "name" and never ever use unbalanced "if"s in macros.
Alternatively: Why don't we just use an inline function instead of the
macro? This would be nicer...
https://codereview.chromium.org/186163002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
