Thx for the review/discussion, here are updates,
--Michael
https://codereview.chromium.org/178463007/diff/80001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/178463007/diff/80001/src/compiler.cc#newcode264
src/compiler.cc:264:
*TypeFeedbackInfo::UninitializedSentinel(isolate()));
On 2014/03/05 07:22:56, Benedikt Meurer wrote:
Nit: indentation
Done.
https://codereview.chromium.org/178463007/diff/80001/src/compiler.cc#newcode267
src/compiler.cc:267: feedback_vector_ =
isolate()->factory()->NewFixedArrayWithHoles(length,
On 2014/03/05 07:22:56, Benedikt Meurer wrote:
Nit: put arguments on next line.
Done.
https://codereview.chromium.org/178463007/diff/80001/src/compiler.cc#newcode592
src/compiler.cc:592:
shared->set_feedback_vector(*(info->feedback_vector()));
On 2014/03/05 07:22:56, Benedikt Meurer wrote:
Nit: *info->feedback_vector()
Done.
https://codereview.chromium.org/178463007/diff/80001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/178463007/diff/80001/src/hydrogen.cc#newcode7228
src/hydrogen.cc:7228:
target_shared->set_feedback_vector(*(target_info.feedback_vector()));
On 2014/03/05 07:22:56, Benedikt Meurer wrote:
Nit: *target_info.feedback_vector()
Done.
https://codereview.chromium.org/178463007/diff/80001/src/objects-printer.cc
File src/objects-printer.cc (right):
https://codereview.chromium.org/178463007/diff/80001/src/objects-printer.cc#newcode880
src/objects-printer.cc:880: feedback_vector()->ShortPrint(out);
On 2014/03/05 07:22:56, Benedikt Meurer wrote:
Why don't you use FixedArrayPrint() here?
good idea, thx.
https://codereview.chromium.org/178463007/diff/80001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/178463007/diff/80001/src/objects.cc#newcode10655
src/objects.cc:10655: if (!obj->IsAllocationSite()) {
On 2014/03/05 07:22:56, Benedikt Meurer wrote:
Unrelated to this CL, but... Do we really want to keep all these
special cases
for allocation sites?
Indeed, per our discussion, I'll try and remove the special case in
another CL.
https://codereview.chromium.org/178463007/diff/80001/src/objects.cc#newcode10657
src/objects.cc:10657: TypeFeedbackInfo::RawUninitializedSentinel(heap));
On 2014/03/05 07:22:56, Benedikt Meurer wrote:
Nit: Please add a comment that this ASSERT is only necessary for the
SKIP_WRITE_BARRIER below.
Done.
https://codereview.chromium.org/178463007/diff/80001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/178463007/diff/80001/src/runtime.cc#newcode8562
src/runtime.cc:8562:
function->shared()->ClearTypeFeedbackInfo(isolate->heap());
On 2014/03/05 07:22:56, Benedikt Meurer wrote:
This should be done unconditionally.
Done.
https://codereview.chromium.org/178463007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
