lgtm
https://codereview.chromium.org/177983003/diff/20001/src/allocation-tracker.cc
File src/allocation-tracker.cc (right):
https://codereview.chromium.org/177983003/diff/20001/src/allocation-tracker.cc#newcode148
src/allocation-tracker.cc:148:
ranges_.insert(RangeMap::value_type(start, new_range));
I have a feeling that using the 'end' address as a key might simplify
the lookup algorithm.
https://codereview.chromium.org/177983003/diff/20001/src/allocation-tracker.cc#newcode157
src/allocation-tracker.cc:157: if (it->first <= addr && addr <
it->second.end) {
it->first <= addr seems to be always true.
https://codereview.chromium.org/177983003/diff/20001/src/allocation-tracker.cc#newcode163
src/allocation-tracker.cc:163: if (it->first == addr) return
it->second.trace_node_id;
if you use upper_bound instead you won't need to do this check.
https://codereview.chromium.org/177983003/diff/20001/src/allocation-tracker.cc#newcode166
src/allocation-tracker.cc:166: if (it->first <= addr && addr <
it->second.end) {
ditto for it->first <= addr
https://codereview.chromium.org/177983003/diff/20001/src/allocation-tracker.cc#newcode220
src/allocation-tracker.cc:220: while (it != ranges_.end() && it->first
< end) {
extra space
https://codereview.chromium.org/177983003/diff/20001/src/allocation-tracker.h
File src/allocation-tracker.h (right):
https://codereview.chromium.org/177983003/diff/20001/src/allocation-tracker.h#newcode93
src/allocation-tracker.h:93: void Print();
I think it should be put behind OBJECT_PRINT
https://codereview.chromium.org/177983003/diff/20001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/177983003/diff/20001/src/heap-snapshot-generator.cc#newcode402
src/heap-snapshot-generator.cc:402: if (from == to) return false;
true?
https://codereview.chromium.org/177983003/diff/20001/src/heap-snapshot-generator.cc#newcode2659
src/heap-snapshot-generator.cc:2659: // type, name, id, self_size,
children_index, trace_node_id.
children_index -> edge_count ;-)
https://codereview.chromium.org/177983003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
