LGTM with one comment.
https://codereview.chromium.org/188543004/diff/1/src/hydrogen-gvn.cc
File src/hydrogen-gvn.cc (right):
https://codereview.chromium.org/188543004/diff/1/src/hydrogen-gvn.cc#newcode453
src/hydrogen-gvn.cc:453: stream->Add("[%p]",
*global_vars_[index].handle());
See comment below.
https://codereview.chromium.org/188543004/diff/1/src/hydrogen-gvn.cc#newcode479
src/hydrogen-gvn.cc:479: *cell.handle(), num_global_vars_);
Dereferencing the handle here will not work if we are on the compiler
thread. We could print the hashcode of the Unique instead. On the other
hand, cells are not relocated, so we could broaden the assert.
https://codereview.chromium.org/188543004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
