https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64.cc#newcode4939
src/a64/macro-assembler-a64.cc:4939: ASSERT(!AreAliased(dividend,
result, tmp));
Also assert that result and dividend are W registers.
https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64.cc#newcode4943
src/a64/macro-assembler-a64.cc:4943: Mov(result.X(), Operand(result.X(),
ASR, 32));
Asr(result.X(), result.X(), 32);
https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64.cc#newcode4945
src/a64/macro-assembler-a64.cc:4945: Add(result, result,
Operand(dividend));
Don't need Operand here.
https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64.cc#newcode4948
src/a64/macro-assembler-a64.cc:4948: Sub(result, result,
Operand(dividend));
Don't need Operand here.
https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64.cc#newcode4950
src/a64/macro-assembler-a64.cc:4950: if (ms.shift() > 0) Mov(result,
Operand(result, ASR, ms.shift()));
Asr(result, result, ms.shift());
https://codereview.chromium.org/190383002/diff/20001/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):
https://codereview.chromium.org/190383002/diff/20001/src/a64/lithium-codegen-a64.cc#newcode2633
src/a64/lithium-codegen-a64.cc:2633: __ Cmp(dividend, 0);
DeoptimizeIfZero()
https://codereview.chromium.org/190383002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
