LGTM, only nits and naming.
https://codereview.chromium.org/179813005/diff/1/src/assembler.h
File src/assembler.h (right):
https://codereview.chromium.org/179813005/diff/1/src/assembler.h#newcode415
src/assembler.h:415: INLINE(Address constant_pool_entry_address());
nit: Let's add an empty newline for readability after the declaration.
https://codereview.chromium.org/179813005/diff/1/src/liveedit.cc
File src/liveedit.cc (right):
https://codereview.chromium.org/179813005/diff/1/src/liveedit.cc#newcode1028
src/liveedit.cc:1028:
*reinterpret_cast<Address*>(target_address_pointer) =
substitution_entry;
Can we instead of the reinterpret cast use ...
Memory::Address_at(target_address_pointer) = substitution_entry;
https://codereview.chromium.org/179813005/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/179813005/diff/1/src/mark-compact.cc#newcode2923
src/mark-compact.cc:2923:
*reinterpret_cast<Address*>(target_address_pointer) =
Instead of the reinterpret case, case we use ...
Memory::Address_at(target_address_pointer) =
Code::cast(target)->instruction_start();
https://codereview.chromium.org/179813005/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/179813005/diff/1/src/objects.cc#newcode10262
src/objects.cc:10262: void ObjectVisitor::VisitCodeTargetCommon(Address
target_address) {
IMHO, the logic in here is small enough so that we can inline into the
two callers and get rid of the common helper. I think that's easier to
read.
https://codereview.chromium.org/179813005/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/179813005/diff/1/src/objects.h#newcode10702
src/objects.h:10702: virtual void VisitCodeTarget(Address
target_address_pointer);
Can we rename this to method to make it explicit that it is a constant
cool entry. Maybe "VisitConstantPoolCodeTarget" or
"VisitCodeTargetInConstantPool"?
https://codereview.chromium.org/179813005/diff/1/src/objects.h#newcode10747
src/objects.h:10747: void VisitCodeTargetCommon(Address target_address);
See comment in the .cc file.
https://codereview.chromium.org/179813005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
