https://codereview.chromium.org/189373006/diff/1/src/a64/lithium-a64.cc
File src/a64/lithium-a64.cc (right):
https://codereview.chromium.org/189373006/diff/1/src/a64/lithium-a64.cc#newcode2237
src/a64/lithium-a64.cc:2237: LOperand* object =
UseRegister(instr->object());
This is difficult to understand and to keep in sync with codegen. I hope
it pays off with performance improvement.
To make reading a little bit easier, could you please rearrange the
conditions to mirror the structure of codegen?
Along these lines:
if (instr->access().IsExternalMemory() ||
instr->field_representation().IsDouble()) {
...
} else if (instr->NeedsWriteBarrierForMap() ||
instr->NeedsWriteBarrier()) {
...
} else {
...
}
https://codereview.chromium.org/189373006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
