On 2014/03/07 10:51:56, ulan wrote:
Looks good. One question:
https://codereview.chromium.org/188253005/diff/1/src/a64/assembler-a64.cc
File src/a64/assembler-a64.cc (right):
https://codereview.chromium.org/188253005/diff/1/src/a64/assembler-a64.cc#newcode2678
src/a64/assembler-a64.cc:2678: RelocInfo::VENEER_POOL,
static_cast<intptr_t>(pool_size),
Are there test checking that we read the size correctly in disassembler or
debugger?
There were debugger tests implicitly testing it. I added a simple test for
this.
I also fixed the assembler to only record the veneer pool size when debugger
support is required.
https://codereview.chromium.org/188253005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
