Reviewers: ulan, Rodolph Perfetta (ARM),
Message:
This CL introduces the ool constant pool on arm support. I've tried to
split up
the massive patch-set into a set of manageable CLs for reviewing (the list
of
dependent CLs is in the CL description). I have also uploaded the complete
patch-set in case you want to see the context in:
https://codereview.chromium.org/191313002
There are still a couple of failures in arm.debug.check if
FLAG_ool_constant_pool is enabled - mainly to do with:
- Call sizes not always being the expected size (e.g., if the constant
pool is
not available / is full).
- Embedded objects not being treated weakly in optimized code by the
VisitConstantPoolArray gc visitor.
I will look into addressing these next.
PTAL
Description:
Add out-of-line constant pool support to Arm.
This CL adds out-of-line constant pool support to Arm. A
ConstantPoolBuilder
object is introduced to manage building of the ConstantPoolArray for a given
code object.
This CL depends on the following CLs landing first:
https://codereview.chromium.org/138503002/
https://codereview.chromium.org/179813005/
https://codereview.chromium.org/183553003/
https://codereview.chromium.org/183803022/
https://codereview.chromium.org/183883011/
https://codereview.chromium.org/186733006/
https://codereview.chromium.org/188063002/
https://codereview.chromium.org/190793002/
https://codereview.chromium.org/190823002/
https://codereview.chromium.org/190833002/
https://codereview.chromium.org/190883002/
Please review this at https://codereview.chromium.org/191233003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+527, -101 lines):
M src/a64/assembler-a64.h
M src/a64/assembler-a64.cc
M src/arm/assembler-arm-inl.h
M src/arm/assembler-arm.h
M src/arm/assembler-arm.cc
M src/arm/builtins-arm.cc
M src/arm/code-stubs-arm.cc
M src/arm/macro-assembler-arm.h
M src/arm/macro-assembler-arm.cc
M src/assembler.h
M src/disassembler.cc
M src/heap.cc
M src/ia32/assembler-ia32.h
M src/ia32/assembler-ia32.cc
M src/objects.h
M src/v8globals.h
M src/x64/assembler-x64.h
M src/x64/assembler-x64.cc
M test/cctest/test-reloc-info.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
