Addressed initialization and verification of code entrys - PTAL.
https://codereview.chromium.org/183883011/diff/80001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/183883011/diff/80001/src/heap.cc#newcode5312
src/heap.cc:5312: if (number_of_heap_ptr_entries > 0) {
On 2014/03/07 15:07:47, Michael Starzinger wrote:
Can we really skip initializing the code_ptr_entries here? IIUC they
might be
visited before being set by the caller, so we should initialize. One
valid
initialization value would be the entry point of the
Builtins::kIllegal builtin.
Yes I think you are right. At the moment I don't think it's possible
for a GC to happen between a ConstantPoolArray being allocated and it's
code target entries being populated, but that might not always be the
case. Done (with Builtins::kIllegal).
https://codereview.chromium.org/183883011/diff/80001/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/183883011/diff/80001/src/objects-debug.cc#newcode409
src/objects-debug.cc:409: }
On 2014/03/07 15:07:47, Michael Starzinger wrote:
Can we also verify that all code_ptr entries point to code entry
locations?
Done.
https://codereview.chromium.org/183883011/diff/80001/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://codereview.chromium.org/183883011/diff/80001/src/objects-visiting-inl.h#newcode493
src/objects-visiting-inl.h:493: int offset =
constant_pool->OffsetOfElementAt(
On 2014/03/07 15:07:47, Michael Starzinger wrote:
nit: Two white-spaces after equal sign.
Done.
https://codereview.chromium.org/183883011/diff/80001/src/objects-visiting-inl.h#newcode499
src/objects-visiting-inl.h:499: int offset =
constant_pool->OffsetOfElementAt(
On 2014/03/07 15:07:47, Michael Starzinger wrote:
nit: Two white-spaces after equal sign.
Done.
https://codereview.chromium.org/183883011/diff/80001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/183883011/diff/80001/src/objects.cc#newcode9470
src/objects.cc:9470: int offset =
OffsetOfElementAt(first_code_ptr_index() + i);
On 2014/03/07 15:07:47, Michael Starzinger wrote:
nit: Two white-spaces after equal sign.
Done.
https://codereview.chromium.org/183883011/diff/80001/src/objects.cc#newcode9475
src/objects.cc:9475: int offset =
OffsetOfElementAt(first_heap_ptr_index() + i);
On 2014/03/07 15:07:47, Michael Starzinger wrote:
nit: Two white-spaces after equal sign.
Done.
https://codereview.chromium.org/183883011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
