On 2014/03/07 18:32:35, Jakob wrote:
LGTM with comments.
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instructions.cc#newcode3142
src/hydrogen-instructions.cc:3142: }
I think you're missing a "return true;" here.
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instructions.h#newcode3644
src/hydrogen-instructions.h:3644: bool is_internalized_string_ : 1; //
TODO(yangguo): make this part of HType.
I think we don't need this any more.
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instructions.h#newcode4579
src/hydrogen-instructions.h:4579: : HUnaryControlInstruction(value, NULL,
NULL),
nit: indentation was correct before
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instructions.h#newcode4583
src/hydrogen-instructions.h:4583: bool compares_number_type_ : 1;
is this still used anywhere?
Thanks for the review! Issues addressed and uploaded in a new patch set.
https://codereview.chromium.org/174863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
