LGTM, just a few nits.
https://codereview.chromium.org/183883011/diff/100001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/183883011/diff/100001/src/heap.h#newcode1013
src/heap.h:1013: int first_int64_index,
nit: For the sake of consistency could we prefix the argument names with
"number_of_" here as well? Otherwise someone reading just this
declaration might get confused.
https://codereview.chromium.org/183883011/diff/100001/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/183883011/diff/100001/src/objects-debug.cc#newcode410
src/objects-debug.cc:410: CHECK(IsConstantPoolArray());
nit: Let's move this check to the top of the method.
https://codereview.chromium.org/183883011/diff/100001/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://codereview.chromium.org/183883011/diff/100001/src/objects-visiting-inl.h#newcode493
src/objects-visiting-inl.h:493: int offset =
constant_pool->OffsetOfElementAt(
nit: Can we use RawFieldOfElementAt he instead? That would be easier to
read I think.
https://codereview.chromium.org/183883011/diff/100001/src/objects-visiting-inl.h#newcode499
src/objects-visiting-inl.h:499: int offset =
constant_pool->OffsetOfElementAt(
nit: Can we use RawFieldOfElementAt he instead? That would be easier to
read I think.
https://codereview.chromium.org/183883011/diff/100001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/183883011/diff/100001/src/objects.cc#newcode9470
src/objects.cc:9470: int offset =
OffsetOfElementAt(first_code_ptr_index() + i);
nit: Can we use RawFieldOfElementAt he instead? That would be easier to
read I think.
https://codereview.chromium.org/183883011/diff/100001/src/objects.cc#newcode9475
src/objects.cc:9475: int offset =
OffsetOfElementAt(first_heap_ptr_index() + i);
nit: Can we use RawFieldOfElementAt he instead? That would be easier to
read I think.
https://codereview.chromium.org/183883011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
