Updates:
        Owner: [email protected]

Comment #1 on issue 3118 by [email protected]: Improve costant folding of typeof x === <typename>
http://code.google.com/p/v8/issues/detail?id=3118

r19759 replaces the typeof-is-and-branch with a constant.


0x51d48d44 36 b991803058 mov ecx,0x58308091 ;; object: 0x58308091 <undefined>
0x51d48d49    41  33c0           xor eax,eax
;;; <@14,#21> -------------------- B2 (loop header) --------------------
                  ;;; <@17,#25> compare-numeric-and-branch
0x51d48d4b 43 3dd0070000 cmp eax,0x7d0 ;; debug: position 56
0x51d48d50    48  0f8d16000000   jnl 76  (0x51d48d6c)
;;; <@18,#26> -------------------- B3 (unreachable/replaced) --------------------
                  ;;; <@22,#32> -------------------- B4 --------------------
                  ;;; <@24,#34> stack-check
0x51d48d56    54  3b25841ab409   cmp esp,[0x9b41a84]
0x51d48d5c    60  0f8212000000   jc 84  (0x51d48d74)
                  ;;; <@28,#42> -------------------- B5 --------------------
                  ;;; <@30,#44> gap
0x51d48d62 66 b9c1803058 mov ecx,0x583080c1 ;; debug: position 88 ;; object: 0x583080c1 <false> ;;; <@32,#39> -------------------- B6 (unreachable/replaced) --------------------
                  ;;; <@36,#46> -------------------- B7 --------------------
                  ;;; <@38,#50> add-i
0x51d48d67 71 83c002 add eax,0x2 ;; debug: position 65
                  ;;; <@41,#53> goto
0x51d48d6a    74  ebdf           jmp 43  (0x51d48d4b)
;;; <@42,#29> -------------------- B8 (unreachable/replaced) --------------------
                  ;;; <@46,#54> -------------------- B9 --------------------
                  ;;; <@47,#54> gap
0x51d48d6c    76  89c8           mov eax,ecx
                  ;;; <@48,#57> return



Next step would be hoisting the constant out of the loop and eliminating that loop. Also, we are still loading that "undefined" string.


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to