https://codereview.chromium.org/190833002/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/190833002/diff/1/src/arm/full-codegen-arm.cc#newcode4844
src/arm/full-codegen-arm.cc:4844:
Assembler::IsMovT(Memory::int32_at(immediate_load_address))) {
Is there a case where ool is enable and we don't have a movt here?
https://codereview.chromium.org/190833002/diff/1/src/arm/full-codegen-arm.cc#newcode4858
src/arm/full-codegen-arm.cc:4858: int branch_offset = (2 * kInstrSize) +
(pc - pc_immediate_load_address);
Some comments about the 2 * kInstrSize would be nice
https://codereview.chromium.org/190833002/diff/1/src/arm/full-codegen-arm.cc#newcode4862
src/arm/full-codegen-arm.cc:4862: patcher.masm()->b(branch_offset, pl);
While I agree the encoding isn't that interesting, having the patched
code sequence as comments make the code easier to read. Admittedly this
is a bit more complicated now.
https://codereview.chromium.org/190833002/diff/1/src/arm/full-codegen-arm.cc#newcode4863
src/arm/full-codegen-arm.cc:4863:
ASSERT(Assembler::IsBranch(Assembler::instr_at(branch_address)));
This assert check that b(...) will emit a branch, is that useful?
https://codereview.chromium.org/190833002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
