Thanks for comments!
https://codereview.chromium.org/186723005/diff/120001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1005
include/v8.h:1005: class V8_EXPORT ContextUnboundScript {
On 2014/03/10 15:50:35, dcarney wrote:
maybe just UnboundScript?
Done.
https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1010
include/v8.h:1010: Local<Script> BindToGlobalContext();
On 2014/03/10 15:50:35, dcarney wrote:
should be bindtocurrentcontext
Done.
https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1015
include/v8.h:1015: Local<Value> Run();
On 2014/03/10 15:50:35, dcarney wrote:
i don't think this should be here
This helper was doing BindToCurrentContext()->Run();, but removed it
now..
https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1054
include/v8.h:1054: int GetId() {
On 2014/03/10 15:50:35, dcarney wrote:
can we deprecate any of these?
GetId is the only one used by chromium -> deprecated the other 2.
... or do we want to remove them instead? (This is a breaking API change
anyway.)
https://codereview.chromium.org/186723005/diff/120001/include/v8.h#newcode1119
include/v8.h:1119: struct V8_EXPORT CompileOptions {
On 2014/03/10 15:50:35, dcarney wrote:
an enum should be enough here, with kNoCompileOptions being the
default
Done.
https://codereview.chromium.org/186723005/diff/120001/src/api.h
File src/api.h (right):
https://codereview.chromium.org/186723005/diff/120001/src/api.h#newcode186
src/api.h:186: V(Script, Object) \
On 2014/03/10 15:50:35, dcarney wrote:
JSFunction
Done.
https://codereview.chromium.org/186723005/diff/120001/src/api.h#newcode187
src/api.h:187: V(ContextUnboundScript, Object) \
On 2014/03/10 15:50:35, dcarney wrote:
can this not be SharedFunctionInfo?
Done.
https://codereview.chromium.org/186723005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
