LGTM with nits
https://codereview.chromium.org/194663003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/194663003/diff/1/include/v8.h#newcode1417
include/v8.h:1417: * This is an experimental feature. Only works with
--harmony flag.
Hopefully this works without --harmony, too (and returns false in that
case).
https://codereview.chromium.org/194663003/diff/1/src/contexts.h
File src/contexts.h (right):
https://codereview.chromium.org/194663003/diff/1/src/contexts.h#newcode176
src/contexts.h:176: V(PROMISE_CATCH_INDEX, JSFunction, promise_catch) \
Hmmm, I think this shouldn't make a difference, but anyway: Please run
"make grokdump" and see if it doesn't change tools/v8heapconst.py.
https://codereview.chromium.org/194663003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
