Reviewers: jochen,
Message:
Committed patchset #1 manually as r19806 (presubmit successful).
Description:
A64: Debug code should assert on unexpected situation.
[email protected]
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=19806
Please review this at https://codereview.chromium.org/184533002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -2 lines):
M src/a64/lithium-codegen-a64.cc
Index: src/a64/lithium-codegen-a64.cc
diff --git a/src/a64/lithium-codegen-a64.cc b/src/a64/lithium-codegen-a64.cc
index
2bad671197fec3743a3ece7c0d1815a2a90a55d1..00ba56a99c2adb08574ef30e0cd9c787bd527901
100644
--- a/src/a64/lithium-codegen-a64.cc
+++ b/src/a64/lithium-codegen-a64.cc
@@ -3665,8 +3665,7 @@ void
LCodeGen::DoDeferredMathAbsTagged(LMathAbsTagged* instr,
Register input = ToRegister(instr->value());
__ JumpIfSmi(result, &result_ok);
__ Cmp(input, result);
- // TODO(all): Shouldn't we assert here?
- DeoptimizeIf(ne, instr->environment());
+ __ Assert(eq, kUnexpectedValue);
__ Bind(&result_ok);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
