Revision: 19809
Author: [email protected]
Date: Tue Mar 11 15:50:01 2014 UTC
Log: A64: Tidy up a couple of TODOs.
[email protected]
Review URL: https://codereview.chromium.org/189883006
http://code.google.com/p/v8/source/detail?r=19809
Modified:
/branches/bleeding_edge/src/a64/code-stubs-a64.cc
/branches/bleeding_edge/src/a64/ic-a64.cc
/branches/bleeding_edge/src/a64/macro-assembler-a64.cc
=======================================
--- /branches/bleeding_edge/src/a64/code-stubs-a64.cc Tue Mar 11 15:03:36
2014 UTC
+++ /branches/bleeding_edge/src/a64/code-stubs-a64.cc Tue Mar 11 15:50:01
2014 UTC
@@ -4941,8 +4941,7 @@
void StubFailureTrampolineStub::Generate(MacroAssembler* masm) {
- // TODO(jbramley): The ARM code leaves the (shifted) offset in r1. Why?
- CEntryStub ces(1, kSaveFPRegs);
+ CEntryStub ces(1, fp_registers_ ? kSaveFPRegs : kDontSaveFPRegs);
__ Call(ces.GetCode(masm->isolate()), RelocInfo::CODE_TARGET);
int parameter_count_offset =
StubFailureTrampolineFrame::kCallerStackParameterCountFrameOffset;
=======================================
--- /branches/bleeding_edge/src/a64/ic-a64.cc Tue Mar 11 14:41:22 2014 UTC
+++ /branches/bleeding_edge/src/a64/ic-a64.cc Tue Mar 11 15:50:01 2014 UTC
@@ -474,12 +474,8 @@
__ IncrementCounter(isolate->counters()->load_miss(), 1, x3, x4);
- // TODO(jbramley): Does the target actually expect an argument in x3, or
is
- // this inherited from ARM's push semantics?
- __ Mov(x3, x0);
- __ Push(x3, x2);
-
// Perform tail call to the entry.
+ __ Push(x0, x2);
ExternalReference ref =
ExternalReference(IC_Utility(kLoadIC_Miss), isolate);
__ TailCallExternalReference(ref, 2, 1);
@@ -493,11 +489,7 @@
// -- x0 : receiver
// -----------------------------------
- // TODO(jbramley): Does the target actually expect an argument in x3, or
is
- // this inherited from ARM's push semantics?
- __ Mov(x3, x0);
- __ Push(x3, x2);
-
+ __ Push(x0, x2);
__ TailCallRuntime(Runtime::kGetProperty, 2, 1);
}
@@ -985,8 +977,6 @@
// We have to go to the runtime if the current value is the hole because
there
// may be a callback on the element.
Label holecheck_passed;
- // TODO(all): This address calculation is repeated later (for the store
- // itself). We should keep the result to avoid doing the work twice.
__ Add(x10, elements, FixedArray::kHeaderSize - kHeapObjectTag);
__ Add(x10, x10, Operand::UntagSmiAndScale(key, kPointerSizeLog2));
__ Ldr(x11, MemOperand(x10));
@@ -1039,8 +1029,6 @@
// HOLECHECK: guards "A[i] double hole?"
// We have to see if the double version of the hole is present. If so go
to
// the runtime.
- // TODO(all): This address calculation was done earlier. We should keep
the
- // result to avoid doing the work twice.
__ Add(x10, elements, FixedDoubleArray::kHeaderSize - kHeapObjectTag);
__ Add(x10, x10, Operand::UntagSmiAndScale(key, kPointerSizeLog2));
__ Ldr(x11, MemOperand(x10));
=======================================
--- /branches/bleeding_edge/src/a64/macro-assembler-a64.cc Mon Mar 10
16:25:15 2014 UTC
+++ /branches/bleeding_edge/src/a64/macro-assembler-a64.cc Tue Mar 11
15:50:01 2014 UTC
@@ -1516,12 +1516,7 @@
void MacroAssembler::AssertName(Register object) {
if (emit_debug_code()) {
- STATIC_ASSERT(kSmiTag == 0);
- // TODO(jbramley): Add AbortIfSmi and related functions.
- Label not_smi;
- JumpIfNotSmi(object, ¬_smi);
- Abort(kOperandIsASmiAndNotAName);
- Bind(¬_smi);
+ AssertNotSmi(object, kOperandIsASmiAndNotAName);
UseScratchRegisterScope temps(this);
Register temp = temps.AcquireX();
@@ -2847,8 +2842,6 @@
ASSERT(StackPointer().Is(jssp));
UseScratchRegisterScope temps(this);
Register temp = temps.AcquireX();
- // TODO(jbramley): Does x1 contain a JSFunction here, or does it
already
- // have the special STUB smi?
__ Mov(temp, Operand(Smi::FromInt(StackFrame::STUB)));
// Compiled stubs don't age, and so they don't need the predictable
code
// ageing sequence.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
