https://codereview.chromium.org/190823002/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/190823002/diff/1/src/arm/full-codegen-arm.cc#newcode2198
src/arm/full-codegen-arm.cc:2198: ConstantPoolUnavailableScope
constant_pool_unavailable(masm_);
On 2014/03/11 13:07:39, ulan wrote:
Shouldn't this scope be
- at the beginning of the "if (resume_mode ==
JSGeneratorObject::NEXT)" branch?
- or inside the "if (FLAG_enable_ool_constant_pool)" branch?
The Constant Pool is unavailable (for this code object) from the ldr(pp,
...) until the Jump(r3) instruction (since between these instructions
it contains the pp for the target function).
I can't put it inside the "if (FLAG_enable_ool_constant_pool) because
the scope would go out of scope before the Jump(r3). I could put it at
the beginning of the if (resume_mode == JSGeneratorObject::NEXT) scope
if you prefer, but I put it here to make it clear that this was related
to the ldr(pp, ..) instruction. If you still prefer moving it to the
beginning of the scope though I'm happy to move it. WDYT?
https://codereview.chromium.org/190823002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
