Revision: 19815
Author: [email protected]
Date: Tue Mar 11 17:31:40 2014 UTC
Log: A64: Tidy up a few TODOs.
[email protected]
Review URL: https://codereview.chromium.org/195363003
http://code.google.com/p/v8/source/detail?r=19815
Modified:
/branches/bleeding_edge/src/a64/assembler-a64.h
/branches/bleeding_edge/src/a64/macro-assembler-a64.cc
/branches/bleeding_edge/src/a64/macro-assembler-a64.h
=======================================
--- /branches/bleeding_edge/src/a64/assembler-a64.h Tue Mar 11 15:03:36
2014 UTC
+++ /branches/bleeding_edge/src/a64/assembler-a64.h Tue Mar 11 17:31:40
2014 UTC
@@ -845,9 +845,6 @@
int InstructionsGeneratedSince(const Label* label) {
return SizeOfCodeGeneratedSince(label) / kInstructionSize;
}
-
- // TODO(all): Initialize these constants related with code patching.
- // TODO(all): Set to -1 to hopefully crash if mistakenly used.
// Number of instructions generated for the return sequence in
// FullCodeGenerator::EmitReturnSequence.
=======================================
--- /branches/bleeding_edge/src/a64/macro-assembler-a64.cc Tue Mar 11
15:50:01 2014 UTC
+++ /branches/bleeding_edge/src/a64/macro-assembler-a64.cc Tue Mar 11
17:31:40 2014 UTC
@@ -1758,11 +1758,13 @@
}
-void MacroAssembler::GetBuiltinEntry(Register target, Builtins::JavaScript
id) {
- ASSERT(!target.is(x1));
- GetBuiltinFunction(x1, id);
+void MacroAssembler::GetBuiltinEntry(Register target,
+ Register function,
+ Builtins::JavaScript id) {
+ ASSERT(!AreAliased(target, function));
+ GetBuiltinFunction(function, id);
// Load the code entry point from the builtins object.
- Ldr(target, FieldMemOperand(x1, JSFunction::kCodeEntryOffset));
+ Ldr(target, FieldMemOperand(function, JSFunction::kCodeEntryOffset));
}
@@ -1773,7 +1775,8 @@
// You can't call a builtin without a valid frame.
ASSERT(flag == JUMP_FUNCTION || has_frame());
- GetBuiltinEntry(x2, id);
+ // Get the builtin entry in x2 and setup the function object in x1.
+ GetBuiltinEntry(x2, x1, id);
if (flag == CALL_FUNCTION) {
call_wrapper.BeforeCall(CallSize(x2));
Call(x2);
=======================================
--- /branches/bleeding_edge/src/a64/macro-assembler-a64.h Mon Mar 10
16:25:15 2014 UTC
+++ /branches/bleeding_edge/src/a64/macro-assembler-a64.h Tue Mar 11
17:31:40 2014 UTC
@@ -1047,7 +1047,6 @@
CallRuntime(Runtime::FunctionForId(id), num_arguments, save_doubles);
}
- // TODO(all): Why does this variant save FP regs unconditionally?
void CallRuntimeSaveDoubles(Runtime::FunctionId id) {
const Runtime::Function* function = Runtime::FunctionForId(id);
CallRuntime(function, function->nargs, kSaveFPRegs);
@@ -1110,9 +1109,10 @@
const CallWrapper& call_wrapper = NullCallWrapper());
// Store the code object for the given builtin in the target register and
- // setup the function in x1.
- // TODO(all): Can we use another register than x1?
- void GetBuiltinEntry(Register target, Builtins::JavaScript id);
+ // setup the function in the function register.
+ void GetBuiltinEntry(Register target,
+ Register function,
+ Builtins::JavaScript id);
// Store the function for the given builtin in the target register.
void GetBuiltinFunction(Register target, Builtins::JavaScript id);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
