LGTM with two nits.
https://codereview.chromium.org/197043004/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/197043004/diff/1/src/runtime.cc#newcode10517
src/runtime.cc:10517: if (object->HasFastArgumentsElements() ||
nit: Instead of putting this logic here, can we move it into
JSObject::PrepareElementsForSort instead?
https://codereview.chromium.org/197043004/diff/1/src/runtime.cc#newcode10518
src/runtime.cc:10518: object->HasDictionaryArgumentsElements() ||
nit: Better use object->HasNonStrictArgumentsElements() instead of
asking for "fast" and "dictionary" separately.
https://codereview.chromium.org/197043004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
