Revision: 19851
Author:   [email protected]
Date:     Wed Mar 12 14:15:13 2014 UTC
Log: Follow-up to r19845 which suppresses syntax errors in presence of a stack overflow.

ReportUnexpectedToken already calls Traits::ReportMessageAt. If we're in Parser, that already suppresses the syntax error. If we're in PreParser, we don't need
to suppress the syntax error (preparser errors don't go through Isolate, and
having both stack overflow and a syntax error present is handled correctly by
PreParserApi::PreParse).

[email protected]
BUG=

Review URL: https://codereview.chromium.org/197293003
http://code.google.com/p/v8/source/detail?r=19851

Modified:
 /branches/bleeding_edge/src/preparser.h

=======================================
--- /branches/bleeding_edge/src/preparser.h     Wed Mar 12 14:03:25 2014 UTC
+++ /branches/bleeding_edge/src/preparser.h     Wed Mar 12 14:15:13 2014 UTC
@@ -1016,12 +1016,6 @@

 template<class Traits>
 void ParserBase<Traits>::ReportUnexpectedToken(Token::Value token) {
-  // We don't report stack overflows here, to avoid increasing the
-  // stack depth even further.  Instead we report it after parsing is
-  // over, in ParseProgram.
-  if (token == Token::ILLEGAL && stack_overflow()) {
-    return;
-  }
   Scanner::Location source_location = scanner()->location();

   // Four of the tokens are treated specially

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to