just a few nits, otherwise looks good to me.
https://codereview.chromium.org/191233003/diff/10001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/191233003/diff/10001/src/arm/assembler-arm.cc#newcode1165
src/arm/assembler-arm.cc:1165: }
nit: indent
https://codereview.chromium.org/191233003/diff/10001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):
https://codereview.chromium.org/191233003/diff/10001/src/arm/builtins-arm.cc#newcode970
src/arm/builtins-arm.cc:970: __ ldr(pp, MemOperand(r0,
Code::kConstantPoolOffset - kHeapObjectTag));
use FieldMemOperand so you don't need to substract the tag.
https://codereview.chromium.org/191233003/diff/10001/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/191233003/diff/10001/src/arm/macro-assembler-arm.cc#newcode932
src/arm/macro-assembler-arm.cc:932: set_constant_pool_available(true);
duplication
https://codereview.chromium.org/191233003/diff/10001/src/arm/macro-assembler-arm.cc#newcode3577
src/arm/macro-assembler-arm.cc:3577: const int32_t kPCRegOffset = 2 *
kPointerSize;
use kPCReadOffset insetad
https://codereview.chromium.org/191233003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
